OTLP not Jaeger #269
Merged
OTLP not Jaeger #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeger spans can be sent as OTLP so this is mostly semantics for the collector, which is more flexible if it accepts OTLP traces rather than jaeger.thrift traces.
DMRobertson
approved these changes
Aug 23, 2023
genofire
reviewed
Jul 23, 2024
| } | ||
| isInsecure := parsedOTLPURL.Scheme == "http" // e.g testing and development | ||
| if parsedOTLPURL.Path != "" { | ||
| return fmt.Errorf("OTLP URL %s cannot contain any path segments", otlpURL) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace exporter span format from Jaeger to OTLP as it's more "generic" and thus works with more server-side stuff.
Also add in the option to set HTTP basic auth on the endpoint.