-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with out-of-sync room state, e.g. due to the last device logging out or leaving the room #18
Comments
(Hashed out in #51 (comment) .) It's true enough that room state in the proxy's DB can become out of date. (Indeed, we suspect that something like this has already happened---there are reports of old room names showing up.) However, deleting everything and starting from scratch is a little nuclear. Instead we can do the following.
Slogan: this makes the proxy "support gappy state" (but not gappy messages). Other notes:
|
Reduces the likelihood of hitting #18.
Reduces the likelihood of hitting #18.
If you have 1 user with 1 device in a room, who then leaves the room, the room data in the DB will eventually go stale. However, if a new user then joins the same room, we will not reset our knowledge of room state (specifically, we discard the
state
in the sync response), and the room state can then diverge from the truth.This isn't terribly dissimilar to when servers leave a room then rejoin the same room - they need to clear their DB when they leave.
The text was updated successfully, but these errors were encountered: