Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Matrix URI scheme actions to include action=knock #1015

Open
Mikaela opened this issue Apr 1, 2022 · 8 comments · May be fixed by matrix-org/matrix-spec-proposals#3780
Open

Expand Matrix URI scheme actions to include action=knock #1015

Mikaela opened this issue Apr 1, 2022 · 8 comments · May be fixed by matrix-org/matrix-spec-proposals#3780
Labels
enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@Mikaela
Copy link

Mikaela commented Apr 1, 2022

Is your feature request related to a problem? Please describe.

Matrix URI scheme currently only mentions actions join and chat.

Describe the solution you'd like

I would like there to be an action knock too, to communicate to developers that this is a usecase that should be handled as knocking has been part of the specification since 1.1

Describe alternatives you've considered

One option would be communicating to clients to knock if join fails.

Additional context

Nheko handles the knock action (and in room gave me a permission to open this issue): Nheko-Reborn/nheko@6f8babc

@Mikaela Mikaela changed the title Expand Matirx URI scheme actions to include action=knock Expand Matrix URI scheme actions to include action=knock Apr 1, 2022
@turt2live turt2live transferred this issue from matrix-org/matrix-spec-proposals Apr 1, 2022
Mikaela added a commit to Mikaela/matrix-spec that referenced this issue Apr 17, 2022
Mikaela added a commit to Mikaela/matrix-spec that referenced this issue Apr 17, 2022
Mikaela added a commit to Mikaela/matrix-spec that referenced this issue Apr 17, 2022
@turt2live turt2live added the enhancement A suggestion for a relatively simple improvement to the protocol label Apr 17, 2022
@ShadowJonathan
Copy link
Contributor

Wouldn’t this be covered under action=join?

Couldn’t that spec segment be reworded to include “knock” as a valid action?

(cc @turt2live and @KitsuneRal)

@KitsuneRal
Copy link
Member

Yes, and it takes a pretty small straightforward MSC, before adding it to the spec text. How about drafting one? :)

@ShadowJonathan
Copy link
Contributor

Sounds good, I talked to @Mikaela and Nico (from Nheko) about it, and so I'll make that MSC

@Mikaela
Copy link
Author

Mikaela commented Apr 18, 2022

Would this also be reflected in matrix.to handling or does it need a different issue?

@KitsuneRal
Copy link
Member

matrix.to predates Matrix URIs and doesn't abide by their conventions. You'll have to submit a separate issue at its repo.

@turt2live
Copy link
Member

the spec for matrix.to exists on our end though? The project's support is of course a different issue, but the specification for what it should do is needed here.

@Mikaela
Copy link
Author

Mikaela commented Apr 26, 2022

I am having difficulties getting to my mindset 8 days ago on what exactly is the issue on matrix.to side considering it just attempts to open clients and offers commands. Should it be aware of join_rule and offer /knock for Nheko users instead of join? Won't clients just offee knocking if join fails as per #3780? If not, isn't that client rather than matrix.to issue or even another spec issue?

@turt2live
Copy link
Member

it should just work with the clients, but if matrix.to is translating the link into something for the client to open with then matrix.to needs to be aware of how to do that for the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
4 participants