Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4190: Device management for application services #4190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Sep 12, 2024

Rendered

Synapse implementation:


In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am a Software Engineer at Element. This proposal was written and published as an Element employee.

@sandhose sandhose changed the title Device management for application services MSC4190: Device management for application services Sep 12, 2024
@sandhose sandhose marked this pull request as ready for review September 12, 2024 13:17
@turt2live turt2live added proposal A matrix spec change proposal application services kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 12, 2024
Copy link
Member

@turt2live turt2live Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

Edit: @anoadragon453 and @tulir have updated the above.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appservice implementation: mautrix/go#288

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just a couple sticking points.


### **`POST /_matrix/client/v3/register`**

This endpoint no longer generates a new access token, as if `inhibit_login` was set to `true` in the request by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This endpoint no longer generates a new access token, as if `inhibit_login` was set to `true` in the request by default.
This endpoint no longer generates a new access token for application services, as if `inhibit_login` was set to `true` in the request by default.


This endpoint no longer requires User-Interactive Authentication for application services.

### **`POST /_matrix/client/v3/register`**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump this to /v4 here as this is technically a backwards-incompatible change. Curious on your thoughts of whether that would be too impractical.

While the unstable io.element.msc4190 flag guards application services for now, it will disappear once this MSC is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application services implementation-needs-checking The MSC has an implementation, but the SCT has not yet checked it. kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants