-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4190: Device management for application services #4190
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements:
- Appservice
- mautrix/go@3cb79ba (implements new
PUT /_matrix/client/v3/devices/{deviceId}
semantics)
- mautrix/go@3cb79ba (implements new
- Server
- Support for MSC4190: device management for application services element-hq/synapse#17705 (implements entire MSC)
Edit: @anoadragon453 and @tulir have updated the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appservice implementation: mautrix/go#288
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, just a couple sticking points.
|
||
### **`POST /_matrix/client/v3/register`** | ||
|
||
This endpoint no longer generates a new access token, as if `inhibit_login` was set to `true` in the request by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint no longer generates a new access token, as if `inhibit_login` was set to `true` in the request by default. | |
This endpoint no longer generates a new access token for application services, as if `inhibit_login` was set to `true` in the request by default. |
|
||
This endpoint no longer requires User-Interactive Authentication for application services. | ||
|
||
### **`POST /_matrix/client/v3/register`** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should bump this to /v4
here as this is technically a backwards-incompatible change. Curious on your thoughts of whether that would be too impractical.
While the unstable io.element.msc4190
flag guards application services for now, it will disappear once this MSC is accepted.
Rendered
Synapse implementation:
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am a Software Engineer at Element. This proposal was written and published as an Element employee.