Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3925: m.replace aggregation with full event #3925

Merged
merged 34 commits into from
Feb 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
116eb4e
init m.replace aggregation with full event
benkuly Nov 3, 2022
88c434d
Rename tmp.md to 3925-replace-aggregation-with-full-event.md
benkuly Nov 3, 2022
5a54a03
Update 3925-replace-aggregation-with-full-event.md
benkuly Nov 3, 2022
a065b00
Update 3925-replace-aggregation-with-full-event.md
benkuly Nov 3, 2022
4f5ecde
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 4, 2022
6ea5486
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 4, 2022
09602eb
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 8, 2022
3876a46
redact instead of delete
benkuly Nov 8, 2022
97dfdce
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 8, 2022
c0ec33d
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 8, 2022
f7fa717
Merge branch 'main' of github.com:benkuly/matrix-spec-proposals
benkuly Nov 8, 2022
0bba4e4
word wrap 80
benkuly Nov 8, 2022
db0ca3e
remove immutable argument
benkuly Nov 8, 2022
ff6fc37
add alternative from https://github.com/matrix-org/matrix-spec/issues…
benkuly Nov 8, 2022
291b921
add json example
benkuly Nov 8, 2022
8a4f38f
shorter version of the actual proposal
benkuly Nov 8, 2022
e365e01
describe the actual reason, why encrypted events cannot be replaced
benkuly Nov 8, 2022
05ecbe5
mention discussion
benkuly Nov 8, 2022
919edb5
typo
benkuly Nov 8, 2022
8fb8814
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
eac5551
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
5aced11
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
fe75f9c
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
767acad
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
e3a461e
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
b84a03a
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
5bfffb4
clarify inconsistent behavior with replaced contents
benkuly Nov 11, 2022
1ea94a2
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 11, 2022
fae2c26
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 15, 2022
ee0dffa
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 15, 2022
fd37307
Update proposals/3925-replace-aggregation-with-full-event.md
benkuly Nov 15, 2022
efc6060
clarify inconsistent behavior and put it into introduction
benkuly Nov 15, 2022
64da169
remove superfluous event content field
benkuly Feb 8, 2023
3d9e2ab
add some details to potential issues
benkuly Feb 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update proposals/3925-replace-aggregation-with-full-event.md
Co-authored-by: Richard van der Hoff <[email protected]>
benkuly and richvdh authored Nov 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 97dfdcee050325b7ae30396d9fb94a94d1aecea1
2 changes: 1 addition & 1 deletion proposals/3925-replace-aggregation-with-full-event.md
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ The additional server call is already needed for encrypted events and would be s

## Potential issues

* There could be clients, which rely on the current behavior.
* There could be clients which rely on the current behavior.
dbkr marked this conversation as resolved.
Show resolved Hide resolved
* It is not as easy for clients like as in the current spec to get the current content of an event by just looking into `content.body`. While this true, it is also a relatively inconsistent behavior. Future replacements of the event would be rendered as "* new content". So the event with the replaced event does look different (without "*") despite the fact, that it is also replaced.
benkuly marked this conversation as resolved.
Show resolved Hide resolved

## Alternatives