[WIP] MSC3385: Bulk small improvements to room upgrades #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
client-server
turt2live
changed the title
clokep
reviewed
Sep 7, 2021
|
|
||
| ... Others TBD | ||
|
|
||
| **TODO**: Mention how Synapse already does the last two points above. |
There was a problem hiding this comment.
Synapse only copies the m.federate field from the previous create event, it doesn't copy the contents. matrix-org/synapse#10774 changes this slightly to also support spaces, but still doesn't fully copy the contents.
Mikaela
reviewed
Jan 13, 2022
Comment on lines
+22
to
+23
| and `room_version` properties. This ensures details such as the room type (eg: spaces) and federatable | ||
| status are copied to the new room accurately. |
There was a problem hiding this comment.
I guess Synapse is currently not doing this and that is why upgrading a room used by #3588 results to the room not getting recognised and recreated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered