-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial spec for cross-signing #2536
Conversation
Not sure which lines and thus don't know where to do line-comments on the PR, but in |
@@ -233,7 +234,74 @@ paths: | |||
"device_display_name": "Alice's mobile phone" | |||
} | |||
} | |||
|
|||
master_keys: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to only query the cross-signing keys? Is it sufficient to query only one device key of a user to them in the reply, or do you need to query all device keys of a user (empty list)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there's no way to query just the cross-signing keys. Querying device is sufficient. The user's ID just needs to appear in the query.
Yes, that seems to just be the way our documentation generator works. On fact, the whole body is a parameter, but since it doesn't have any listed properties, the documentation generator thinks there's nothing there. |
As a comment that came out of matrix-org/synapse#7594, it's not super obvious that the USK is only used by its owner and isn't sent to other servers over federation (unlike the two other keys), maybe this could be detailed here? |
Words (and diagram!) have been added that hopefully clarify this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks great. a few bits and bobs.
security: | ||
- accessToken: [] | ||
parameters: | ||
- in: body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't working in the rendered output, for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because our generator wants the body to have a fixed set of properties, rather than being a mapping of IDs, so I don't think this can be fixed without making changes to the build system.
schema: | ||
type: object | ||
properties: | ||
failures: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nor this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me
api/server-server/definitions/event-schemas/m.signing_key_update.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard van der Hoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Richard van der Hoff <[email protected]>
Spec PR for #1756
Does not have any mentions of SSSS, since that is not written up yet.
Rendered version of changes at