Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tracing and update API usage #2788

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Bump tracing and update API usage #2788

merged 2 commits into from
Oct 30, 2023

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Oct 30, 2023

Should fix the build with a more recent tracing version. Maybe we shouldn't rely on internal tracing APIs 👀

@bnjbvr bnjbvr requested a review from a team as a code owner October 30, 2023 11:34
@bnjbvr bnjbvr requested review from jplatte and removed request for a team October 30, 2023 11:34
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1da785e) 81.28% compared to head (919b0e9) 81.29%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2788   +/-   ##
=======================================
  Coverage   81.28%   81.29%           
=======================================
  Files         204      204           
  Lines       20968    20968           
=======================================
+ Hits        17044    17045    +1     
+ Misses       3924     3923    -1     
Files Coverage Δ
crates/matrix-sdk-common/src/tracing_timer.rs 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to fix by just not using internal API, but I guess this is a good intermediate step.

@bnjbvr bnjbvr merged commit 9d5e7c5 into main Oct 30, 2023
35 checks passed
@bnjbvr bnjbvr deleted the bump-tracing branch October 30, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants