libolm_migration: make sender_signing_key optional
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empirically, some sessions in the legacy store lack a `keysClaimed` property. In order to accommodate such sessions in the import, we make the property optional.
|
Part of the fix to element-hq/element-web#26894 |
Hywan
approved these changes
Jan 22, 2024
src/libolm_migration.rs
Outdated
Comment on lines
327
to
340
| /// The public ed25519 key of the account that is believed to have initiated | ||
| /// the session, if known. | ||
| /// | ||
| /// If the session was received directly from the creator via an | ||
| /// Olm-encrypte `m.room_key` event, this value is taken from the `keys` | ||
| /// property of the plaintext payload of that event (see | ||
| /// [`m.olm.v1.curve25519-aes-sha2`]). | ||
| /// | ||
| /// If the session was forwarded to us using an [`m.forwarded_room_key`], | ||
| /// this value is a copy of the `sender_claimed_ed25519_key` from the | ||
| /// content of the event. | ||
| /// | ||
| /// [`m.olm.v1.curve25519-aes-sha2`]: https://spec.matrix.org/v1.9/client-server-api/#molmv1curve25519-aes-sha2 | ||
| /// [`m.forwarded_room_key`]: https://spec.matrix.org/v1.9/client-server-api/#mforwarded_room_key |
richvdh
commented
Jan 22, 2024
richvdh
added a commit
that referenced
this pull request
Jan 22, 2024
richvdh
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jan 22, 2024
Fixes element-hq/element-web#26894 Requires matrix-org/matrix-rust-sdk-crypto-wasm#89 (or rather, an update to a version of matrix-rust-sdk-crypto-wasm) which includes it).
github-merge-queue bot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jan 24, 2024
Fixes element-hq/element-web#26894 Requires matrix-org/matrix-rust-sdk-crypto-wasm#89 (or rather, an update to a version of matrix-rust-sdk-crypto-wasm) which includes it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empirically, some sessions in the legacy store lack a
keysClaimedproperty. In order to accommodate such sessions in the import, we make the property optional.