This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
Set relations helper when creating event tile context menu #9253
Merged
turt2live
merged 9 commits into
matrix-org:develop
from
Johennes:johannes/relations-helper
Oct 18, 2022
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
62732f0
Set relations helper when creating event tile context menu
Johennes 2d293ab
Merge branch 'develop' into johannes/relations-helper
Johennes 4b8882e
Add e2e tests
Johennes df44092
Merge branch 'develop' into johannes/relations-helper
Johennes 45c5032
Use idiomatic test names
Johennes 3fa2801
Merge branch 'develop' into johannes/relations-helper
Johennes 67f729c
Merge branch 'develop' into johannes/relations-helper
Johennes f7cc665
Merge branch 'develop' into johannes/relations-helper
Johennes df0b163
Merge branch 'develop' into johannes/relations-helper
turt2live File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, test naming is typically in the following form:
for example, this test would be something like:
in the grand scheme of things it doesn't really matter - just spreading the word for eventual consistency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that was my understanding, too. I just followed the style used in the other test methods in this file. I've switched all of them over to the idiomatic format now.