Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Read receipts for threads proof of concept (MSC3771) #9130

Closed
wants to merge 7 commits into from

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 3, 2022

Related to matrix-org/matrix-spec-proposals#3771
Fixes element-hq/element-web#22980

To review with matrix-org/matrix-js-sdk#2559


Here's what your changelog entry will look like:

✨ Features

@germain-gg germain-gg added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 3, 2022
@germain-gg germain-gg requested review from clokep and justjanne August 3, 2022 15:13
}

const receiptDestination = this.context.threadId
? room.getThread(this.context.threadId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

room is still optional in props, isn't this going to cause issues here?

@clokep
Copy link
Member

clokep commented Aug 26, 2022

Just removing me review -- overall this looks good and seems to work well!

@germain-gg
Copy link
Contributor Author

There is now a production implementation of this proof of concept

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read receipts for threads proof of concept
3 participants