This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Extract room directory results to its own component #8252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8252 +/- ##
===========================================
+ Coverage 28.57% 28.60% +0.02%
===========================================
Files 862 861 -1
Lines 49809 49761 -48
Branches 12689 12674 -15
===========================================
Hits 14232 14232
+ Misses 35577 35529 -48
|
kerryarchibald
approved these changes
Apr 7, 2022
| @@ -620,7 +487,13 @@ export default class RoomDirectory extends React.Component<IProps, IState> { | |||
| content = <Spinner />; | |||
| } else { | |||
| const cells = (this.state.publicRooms || []) | |||
| .reduce((cells, room) => cells.concat(this.createRoomCells(room)), []); | |||
| .reduce((cells, room) => cells.concat( | |||
There was a problem hiding this comment.
This could just be a map now instead of reduce()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21354
I also remove the unused
RoomDetail*components, I believe they are left-over from the groups deprecationThis change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8252--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.