This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Live location sharing - extract location markers into generic Marker #8225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2022 17:17
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
kerryarchibald
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8225 +/- ##
========================================
Coverage 28.27% 28.28%
========================================
Files 861 862 +1
Lines 49800 49801 +1
Branches 12688 12689 +1
========================================
+ Hits 14083 14085 +2
+ Misses 35717 35716 -1
|
This was referenced Apr 5, 2022
added 2 commits
April 5, 2022 20:00
Signed-off-by: Kerry Archibald <[email protected]>
germain-gg
approved these changes
Apr 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In timeline:
Pin drop:
Static user location:
Live user location (not implemented yet)
Share dialog:
Pin drop:
Static user location:
Live user location:
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8225--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.