Resolve emoji autocomplete not being temporally consistent #8086

commonlawfeature · 2022-03-19T01:19:06Z

Notes: Fix a bug with emoji autocomplete sorting where adding the final ":" would cause the emoji with the typed shortcode to no longer be at the top of the autocomplete list.

Fixes element-hq/element-web#19302

As this is a bugfix, the why is probably best addressed by referencing the related issue (element-hq/element-web#19302).

I have included tests in a separate precursor commit so that it is easy to validate that the issue is fixed by the following commit.

Type: defect

Here's what your changelog entry will look like:

🐛 Bug Fixes

Fix a bug with emoji autocomplete sorting where adding the final ":" would cause the emoji with the typed shortcode to no longer be at the top of the autocomplete list. (#8086). Fixes Emoji autocomplete sorting is not temporally consistent after full shortcode match element-hq/element-web#19302. Contributed by @commonlawfeature.

Preview: https://pr8086--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

test/autocomplete/EmojiProvider-test.js

… in element-hq/element-web#19302. Signed-off-by: Ryan Browne <[email protected]>

Closes element-hq/element-web#19302 Signed-off-by: Ryan Browne <[email protected]>

…onstant. Signed-off-by: Ryan Browne <[email protected]>

src/autocomplete/EmojiProvider.tsx

MadLittleMods · 2022-03-31T20:50:33Z

src/autocomplete/EmojiProvider.tsx

@@ -70,7 +88,7 @@ export default class EmojiProvider extends AutocompleteProvider {
        super({ commandRegex: EMOJI_REGEX, renderingType });
        this.matcher = new QueryMatcher<ISortedEmoji>(SORTED_EMOJI, {
            keys: [],
-            funcs: [o => o.emoji.shortcodes.map(s => `:${s}:`)],
+            funcs: [o => o.emoji.shortcodes.map(s => `${EMOJI_DELIMITER}${s}${EMOJI_DELIMITER}`)],


This fix does work for the most part to at least not switch the emoji from underneath you 👍 and still shows you the exact match.

But does still have some inconsistency with/without the final : with the results within the list itself. Not the end of the world. Just noting a small caveat.

emoji without with final :

:smile:

:hand:

:grinning: . .

Yeah, agreed. I did not have time to look into the other inconsistencies, as they appear to be related to either the search or the scoring. This was just a quick win to get some testing around this area, and fix a particularly annoying bug. I am happy to keep looking into the other inconsistencies as well, but I don't think that those fixes, will be in the same area.

@commonlawfeature Fixing the main problem is a good iteration 👍 Leave the other stuff for another PR/iteration

turt2live

overall I think this seems sane - just a few concerns listed in the comments

src/autocomplete/EmojiProvider.tsx

codecov · 2022-04-04T06:50:34Z

Codecov Report

Merging #8086 (ac09e71) into develop (61076c3) will decrease coverage by 0.67%.
The diff coverage is 100.00%.

❗ Current head ac09e71 differs from pull request most recent head 3989a1f. Consider uploading reports for the commit 3989a1f to get more accurate results

@@             Coverage Diff             @@
##           develop    #8086      +/-   ##
===========================================
- Coverage    29.25%   28.57%   -0.68%     
===========================================
  Files          863      851      -12     
  Lines        49876    49546     -330     
  Branches     12696    12564     -132     
===========================================
- Hits         14592    14160     -432     
- Misses       35284    35386     +102

Impacted Files	Coverage Δ
src/autocomplete/EmojiProvider.tsx	`90.38% <100.00%> (+74.10%)`	⬆️
src/utils/read-receipts.ts	`0.00% <0.00%> (-100.00%)`	⬇️
src/utils/MarkedExecution.ts	`18.18% <0.00%> (-81.82%)`	⬇️
src/components/views/messages/SenderProfile.tsx	`6.25% <0.00%> (-75.00%)`	⬇️
src/components/views/messages/MessageTimestamp.tsx	`0.00% <0.00%> (-72.73%)`	⬇️
src/utils/membership.ts	`13.51% <0.00%> (-67.26%)`	⬇️
src/components/views/audio_messages/SeekBar.tsx	`10.52% <0.00%> (-63.16%)`	⬇️
src/stores/ActiveWidgetStore.ts	`32.25% <0.00%> (-41.94%)`	⬇️
src/widgets/Jitsi.ts	`3.12% <0.00%> (-40.63%)`	⬇️
src/stores/WidgetEchoStore.ts	`17.14% <0.00%> (-37.15%)`	⬇️
... and 407 more

…ence a constant." This reverts commit ac09e71. Signed-off-by: Ryan Browne <[email protected]>

Signed-off-by: Ryan Browne <[email protected]>

commonlawfeature · 2022-04-06T09:53:27Z

@turt2live I appreciate your review, and believe I have addressed your concerns and responded to your and others feedback. Do you mind helping me understand how else I can help get this bug fixed?

turt2live

otherwise looking good - just the colon stripping to worry about. Thanks :)

commonlawfeature · 2022-04-09T05:40:56Z

Adjusted. Thanks!

turt2live · 2022-04-09T05:43:55Z

if you've committed the changes, I'm not seeing them (sorry) - be sure to push :)

Signed-off-by: Ryan Browne <[email protected]>

commonlawfeature · 2022-04-09T05:50:35Z

Apologies. Committed them to an experimental branch by mistake.

turt2live · 2022-04-09T05:52:37Z

(please avoid force pushes after a review has been given, as it makes re-review harder)

commonlawfeature · 2022-04-09T05:54:03Z

Again, apologies. But, unless I misunderstand something, if I have pushed a commit that is not properly signed-off, my only option is a force push to correct the signoff, right?

turt2live · 2022-04-09T05:55:26Z

Signoff can also be provided in the comments or PR description, which saves the signoff in the commit :)

…entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <[email protected]>

…ugh the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0e. Signed-off-by: Ryan Browne <[email protected]>

turt2live

Thanks!

@olivialivia

* Handle forced disconnects from Jitsi ([\#21697](element-hq/element-web#21697)). Fixes element-hq/element-web#21517. * Improve performance of switching to rooms with lots of servers and ACLs ([\#8347](matrix-org/matrix-react-sdk#8347)). * Avoid a reflow when setting caret position on an empty composer ([\#8348](matrix-org/matrix-react-sdk#8348)). * Add message right-click context menu as a labs feature ([\#5672](matrix-org/matrix-react-sdk#5672)). * Live location sharing - basic maximised beacon map ([\#8310](matrix-org/matrix-react-sdk#8310)). * Live location sharing - render users own beacons in timeline ([\#8296](matrix-org/matrix-react-sdk#8296)). * Improve Threads beta around degraded mode ([\#8318](matrix-org/matrix-react-sdk#8318)). * Live location sharing - beacon in timeline happy path ([\#8285](matrix-org/matrix-react-sdk#8285)). * Add copy button to View Source screen ([\#8278](matrix-org/matrix-react-sdk#8278)). Fixes element-hq/element-web#21482. Contributed by @olivialivia. * Add heart effect ([\#6188](matrix-org/matrix-react-sdk#6188)). Contributed by @CicadaCinema. * Update new room icon ([\#8239](matrix-org/matrix-react-sdk#8239)). * Prevent packing of native modules ([\element-hq#337](element-hq#337)). Fixes element-hq/element-web#17188. Contributed by @PF4Public. * Fix: "Code formatting button does not escape backticks" ([\#8181](matrix-org/matrix-react-sdk#8181)). Contributed by @yaya-usman. * Fix beta indicator dot causing excessive CPU usage ([\#8340](matrix-org/matrix-react-sdk#8340)). Fixes element-hq/element-web#21793. * Fix overlapping timestamps on empty messages ([\#8205](matrix-org/matrix-react-sdk#8205)). Fixes element-hq/element-web#21381. Contributed by @goelesha. * Fix power selector not showing up in user info when state_default undefined ([\#8297](matrix-org/matrix-react-sdk#8297)). Fixes element-hq/element-web#21669. * Avoid looking up settings during timeline rendering ([\#8313](matrix-org/matrix-react-sdk#8313)). Fixes element-hq/element-web#21740. * Fix a soft crash with video rooms ([\#8333](matrix-org/matrix-react-sdk#8333)). * Fixes call tiles overflow ([\#8096](matrix-org/matrix-react-sdk#8096)). Fixes element-hq/element-web#20254. Contributed by @luixxiul. * Fix a bug with emoji autocomplete sorting where adding the final "&element-hq#58;" would cause the emoji with the typed shortcode to no longer be at the top of the autocomplete list. ([\#8086](matrix-org/matrix-react-sdk#8086)). Fixes element-hq/element-web#19302. Contributed by @commonlawfeature. * Fix image preview sizing for edge cases ([\#8322](matrix-org/matrix-react-sdk#8322)). Fixes element-hq/element-web#20088. * Refactor SecurityRoomSettingsTab and remove unused state ([\#8306](matrix-org/matrix-react-sdk#8306)). Fixes matrix-org/element-web-rageshakes#12002. * Don't show the prompt to enable desktop notifications immediately after registration ([\#8274](matrix-org/matrix-react-sdk#8274)). * Stop tracking threads if threads support is disabled ([\#8308](matrix-org/matrix-react-sdk#8308)). Fixes element-hq/element-web#21766. * Fix some issues with threads rendering ([\#8305](matrix-org/matrix-react-sdk#8305)). Fixes element-hq/element-web#21670. * Fix threads rendering issue in Safari ([\#8298](matrix-org/matrix-react-sdk#8298)). Fixes element-hq/element-web#21757. * Fix space panel width change on hovering over space item ([\#8299](matrix-org/matrix-react-sdk#8299)). Fixes element-hq/element-web#19891. * Hide the reply in thread button in deployments where beta is forcibly disabled ([\#8294](matrix-org/matrix-react-sdk#8294)). Fixes element-hq/element-web#21753. * Prevent soft crash around room list header context menu when space changes ([\#8289](matrix-org/matrix-react-sdk#8289)). Fixes matrix-org/element-web-rageshakes#11416, matrix-org/element-web-rageshakes#11692, matrix-org/element-web-rageshakes#11739, matrix-org/element-web-rageshakes#11772, matrix-org/element-web-rageshakes#11891 matrix-org/element-web-rageshakes#11858 and matrix-org/element-web-rageshakes#11456. * When selecting reply in thread on a thread response open existing thread ([\#8291](matrix-org/matrix-react-sdk#8291)). Fixes element-hq/element-web#21743. * Handle thread bundled relationships coming from the server via MSC3666 ([\#8292](matrix-org/matrix-react-sdk#8292)). Fixes element-hq/element-web#21450. * Fix: Avatar preview does not update when same file is selected repeatedly ([\#8288](matrix-org/matrix-react-sdk#8288)). Fixes element-hq/element-web#20098. * Fix a bug where user gets a warning when changing powerlevel from **Admin** to **custom level (100)** ([\#8248](matrix-org/matrix-react-sdk#8248)). Fixes element-hq/element-web#21682. Contributed by @Jumeb. * Use a consistent alignment for all text items in a list ([\#8276](matrix-org/matrix-react-sdk#8276)). Fixes element-hq/element-web#21731. Contributed by @luixxiul. * Fixes button labels being collapsed per a character in CJK languages ([\#8212](matrix-org/matrix-react-sdk#8212)). Fixes element-hq/element-web#21287. Contributed by @luixxiul. * Fix: Remove jittery timeline scrolling after jumping to an event ([\#8263](matrix-org/matrix-react-sdk#8263)). * Fix regression of edits showing up in the timeline with hidden events shown ([\#8260](matrix-org/matrix-react-sdk#8260)). Fixes element-hq/element-web#21694. * Fix reporting events not working ([\#8257](matrix-org/matrix-react-sdk#8257)). Fixes element-hq/element-web#21713. * Make Jitsi widgets in video rooms immutable ([\#8244](matrix-org/matrix-react-sdk#8244)). Fixes element-hq/element-web#21647. * Fix: Ensure links to events scroll the correct events into view ([\#8250](matrix-org/matrix-react-sdk#8250)). Fixes element-hq/element-web#19934.

@olivialivia

* Handle forced disconnects from Jitsi ([\element-hq#21697](element-hq#21697)). Fixes element-hq#21517. * Improve performance of switching to rooms with lots of servers and ACLs ([\element-hq#8347](matrix-org/matrix-react-sdk#8347)). * Avoid a reflow when setting caret position on an empty composer ([\element-hq#8348](matrix-org/matrix-react-sdk#8348)). * Add message right-click context menu as a labs feature ([\element-hq#5672](matrix-org/matrix-react-sdk#5672)). * Live location sharing - basic maximised beacon map ([\element-hq#8310](matrix-org/matrix-react-sdk#8310)). * Live location sharing - render users own beacons in timeline ([\element-hq#8296](matrix-org/matrix-react-sdk#8296)). * Improve Threads beta around degraded mode ([\element-hq#8318](matrix-org/matrix-react-sdk#8318)). * Live location sharing - beacon in timeline happy path ([\element-hq#8285](matrix-org/matrix-react-sdk#8285)). * Add copy button to View Source screen ([\element-hq#8278](matrix-org/matrix-react-sdk#8278)). Fixes element-hq#21482. Contributed by @olivialivia. * Add heart effect ([\element-hq#6188](matrix-org/matrix-react-sdk#6188)). Contributed by @CicadaCinema. * Update new room icon ([\element-hq#8239](matrix-org/matrix-react-sdk#8239)). * Fix: "Code formatting button does not escape backticks" ([\element-hq#8181](matrix-org/matrix-react-sdk#8181)). Contributed by @yaya-usman. * Fix beta indicator dot causing excessive CPU usage ([\element-hq#8340](matrix-org/matrix-react-sdk#8340)). Fixes element-hq#21793. * Fix overlapping timestamps on empty messages ([\element-hq#8205](matrix-org/matrix-react-sdk#8205)). Fixes element-hq#21381. Contributed by @goelesha. * Fix power selector not showing up in user info when state_default undefined ([\element-hq#8297](matrix-org/matrix-react-sdk#8297)). Fixes element-hq#21669. * Avoid looking up settings during timeline rendering ([\element-hq#8313](matrix-org/matrix-react-sdk#8313)). Fixes element-hq#21740. * Fix a soft crash with video rooms ([\element-hq#8333](matrix-org/matrix-react-sdk#8333)). * Fixes call tiles overflow ([\#8096](matrix-org/matrix-react-sdk#8096)). Fixes element-hq#20254. Contributed by @luixxiul. * Fix a bug with emoji autocomplete sorting where adding the final "&element-hq#58;" would cause the emoji with the typed shortcode to no longer be at the top of the autocomplete list. ([\element-hq#8086](matrix-org/matrix-react-sdk#8086)). Fixes element-hq#19302. Contributed by @commonlawfeature. * Fix image preview sizing for edge cases ([\element-hq#8322](matrix-org/matrix-react-sdk#8322)). Fixes element-hq#20088. * Refactor SecurityRoomSettingsTab and remove unused state ([\element-hq#8306](matrix-org/matrix-react-sdk#8306)). Fixes matrix-org/element-web-rageshakes#12002. * Don't show the prompt to enable desktop notifications immediately after registration ([\element-hq#8274](matrix-org/matrix-react-sdk#8274)). * Stop tracking threads if threads support is disabled ([\element-hq#8308](matrix-org/matrix-react-sdk#8308)). Fixes element-hq#21766. * Fix some issues with threads rendering ([\element-hq#8305](matrix-org/matrix-react-sdk#8305)). Fixes element-hq#21670. * Fix threads rendering issue in Safari ([\element-hq#8298](matrix-org/matrix-react-sdk#8298)). Fixes element-hq#21757. * Fix space panel width change on hovering over space item ([\element-hq#8299](matrix-org/matrix-react-sdk#8299)). Fixes element-hq#19891. * Hide the reply in thread button in deployments where beta is forcibly disabled ([\element-hq#8294](matrix-org/matrix-react-sdk#8294)). Fixes element-hq#21753. * Prevent soft crash around room list header context menu when space changes ([\element-hq#8289](matrix-org/matrix-react-sdk#8289)). Fixes matrix-org/element-web-rageshakes#11416, matrix-org/element-web-rageshakes#11692, matrix-org/element-web-rageshakes#11739, matrix-org/element-web-rageshakes#11772, matrix-org/element-web-rageshakes#11891 matrix-org/element-web-rageshakes#11858 and matrix-org/element-web-rageshakes#11456. * When selecting reply in thread on a thread response open existing thread ([\#8291](matrix-org/matrix-react-sdk#8291)). Fixes element-hq#21743. * Handle thread bundled relationships coming from the server via MSC3666 ([\element-hq#8292](matrix-org/matrix-react-sdk#8292)). Fixes element-hq#21450. * Fix: Avatar preview does not update when same file is selected repeatedly ([\element-hq#8288](matrix-org/matrix-react-sdk#8288)). Fixes element-hq#20098. * Fix a bug where user gets a warning when changing powerlevel from **Admin** to **custom level (100)** ([\element-hq#8248](matrix-org/matrix-react-sdk#8248)). Fixes element-hq#21682. Contributed by @Jumeb. * Use a consistent alignment for all text items in a list ([\#8276](matrix-org/matrix-react-sdk#8276)). Fixes element-hq#21731. Contributed by @luixxiul. * Fixes button labels being collapsed per a character in CJK languages ([\element-hq#8212](matrix-org/matrix-react-sdk#8212)). Fixes element-hq#21287. Contributed by @luixxiul. * Fix: Remove jittery timeline scrolling after jumping to an event ([\element-hq#8263](matrix-org/matrix-react-sdk#8263)). * Fix regression of edits showing up in the timeline with hidden events shown ([\element-hq#8260](matrix-org/matrix-react-sdk#8260)). Fixes element-hq#21694. * Fix reporting events not working ([\element-hq#8257](matrix-org/matrix-react-sdk#8257)). Fixes element-hq#21713. * Make Jitsi widgets in video rooms immutable ([\element-hq#8244](matrix-org/matrix-react-sdk#8244)). Fixes element-hq#21647. * Fix: Ensure links to events scroll the correct events into view ([\element-hq#8250](matrix-org/matrix-react-sdk#8250)). Fixes element-hq#19934.

@olivialivia

* Improve performance of switching to rooms with lots of servers and ACLs ([\matrix-org#8347](matrix-org#8347)). * Avoid a reflow when setting caret position on an empty composer ([\matrix-org#8348](matrix-org#8348)). * Add message right-click context menu as a labs feature ([\matrix-org#5672](matrix-org#5672)). * Live location sharing - basic maximised beacon map ([\matrix-org#8310](matrix-org#8310)). * Live location sharing - render users own beacons in timeline ([\matrix-org#8296](matrix-org#8296)). * Improve Threads beta around degraded mode ([\matrix-org#8318](matrix-org#8318)). * Live location sharing - beacon in timeline happy path ([\matrix-org#8285](matrix-org#8285)). * Add copy button to View Source screen ([\matrix-org#8278](matrix-org#8278)). Fixes element-hq/element-web#21482. Contributed by @olivialivia. * Add heart effect ([\matrix-org#6188](matrix-org#6188)). Contributed by @CicadaCinema. * Update new room icon ([\matrix-org#8239](matrix-org#8239)). * Fix: "Code formatting button does not escape backticks" ([\matrix-org#8181](matrix-org#8181)). Contributed by @yaya-usman. * Fix beta indicator dot causing excessive CPU usage ([\matrix-org#8340](matrix-org#8340)). Fixes element-hq/element-web#21793. * Fix overlapping timestamps on empty messages ([\matrix-org#8205](matrix-org#8205)). Fixes element-hq/element-web#21381. Contributed by @goelesha. * Fix power selector not showing up in user info when state_default undefined ([\matrix-org#8297](matrix-org#8297)). Fixes element-hq/element-web#21669. * Avoid looking up settings during timeline rendering ([\matrix-org#8313](matrix-org#8313)). Fixes element-hq/element-web#21740. * Fix a soft crash with video rooms ([\matrix-org#8333](matrix-org#8333)). * Fixes call tiles overflow ([\matrix-org#8096](matrix-org#8096)). Fixes element-hq/element-web#20254. Contributed by @luixxiul. * Fix a bug with emoji autocomplete sorting where adding the final "&matrix-org#58;" would cause the emoji with the typed shortcode to no longer be at the top of the autocomplete list. ([\matrix-org#8086](matrix-org#8086)). Fixes element-hq/element-web#19302. Contributed by @commonlawfeature. * Fix image preview sizing for edge cases ([\matrix-org#8322](matrix-org#8322)). Fixes element-hq/element-web#20088. * Refactor SecurityRoomSettingsTab and remove unused state ([\matrix-org#8306](matrix-org#8306)). Fixes matrix-org/element-web-rageshakes#12002. * Don't show the prompt to enable desktop notifications immediately after registration ([\matrix-org#8274](matrix-org#8274)). * Stop tracking threads if threads support is disabled ([\matrix-org#8308](matrix-org#8308)). Fixes element-hq/element-web#21766. * Fix some issues with threads rendering ([\matrix-org#8305](matrix-org#8305)). Fixes element-hq/element-web#21670. * Fix threads rendering issue in Safari ([\matrix-org#8298](matrix-org#8298)). Fixes element-hq/element-web#21757. * Fix space panel width change on hovering over space item ([\matrix-org#8299](matrix-org#8299)). Fixes element-hq/element-web#19891. * Hide the reply in thread button in deployments where beta is forcibly disabled ([\matrix-org#8294](matrix-org#8294)). Fixes element-hq/element-web#21753. * Prevent soft crash around room list header context menu when space changes ([\matrix-org#8289](matrix-org#8289)). Fixes matrix-org/element-web-rageshakes#11416, matrix-org/element-web-rageshakes#11692, matrix-org/element-web-rageshakes#11739, matrix-org/element-web-rageshakes#11772, matrix-org/element-web-rageshakes#11891 matrix-org/element-web-rageshakes#11858 and matrix-org/element-web-rageshakes#11456. * When selecting reply in thread on a thread response open existing thread ([\matrix-org#8291](matrix-org#8291)). Fixes element-hq/element-web#21743. * Handle thread bundled relationships coming from the server via MSC3666 ([\matrix-org#8292](matrix-org#8292)). Fixes element-hq/element-web#21450. * Fix: Avatar preview does not update when same file is selected repeatedly ([\matrix-org#8288](matrix-org#8288)). Fixes element-hq/element-web#20098. * Fix a bug where user gets a warning when changing powerlevel from **Admin** to **custom level (100)** ([\matrix-org#8248](matrix-org#8248)). Fixes element-hq/element-web#21682. Contributed by @Jumeb. * Use a consistent alignment for all text items in a list ([\matrix-org#8276](matrix-org#8276)). Fixes element-hq/element-web#21731. Contributed by @luixxiul. * Fixes button labels being collapsed per a character in CJK languages ([\matrix-org#8212](matrix-org#8212)). Fixes element-hq/element-web#21287. Contributed by @luixxiul. * Fix: Remove jittery timeline scrolling after jumping to an event ([\matrix-org#8263](matrix-org#8263)). * Fix regression of edits showing up in the timeline with hidden events shown ([\matrix-org#8260](matrix-org#8260)). Fixes element-hq/element-web#21694. * Fix reporting events not working ([\matrix-org#8257](matrix-org#8257)). Fixes element-hq/element-web#21713. * Make Jitsi widgets in video rooms immutable ([\matrix-org#8244](matrix-org#8244)). Fixes element-hq/element-web#21647. * Fix: Ensure links to events scroll the correct events into view ([\matrix-org#8250](matrix-org#8250)). Fixes element-hq/element-web#19934.

commonlawfeature requested a review from a team as a code owner March 19, 2022 01:19

commonlawfeature commented Mar 19, 2022

View reviewed changes

test/autocomplete/EmojiProvider-test.js Outdated Show resolved Hide resolved

github-actions bot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Mar 19, 2022

Ryan Browne added 3 commits March 27, 2022 14:54

Adds a test to demonstrate the issue with emoji autocomplete reported…

837f916

… in element-hq/element-web#19302. Signed-off-by: Ryan Browne <[email protected]>

Trim trailing : when checking for autocompletes for emoji.

02566d6

Closes element-hq/element-web#19302 Signed-off-by: Ryan Browne <[email protected]>

Move all references to the emoji delimiter character to reference a c…

ac09e71

…onstant. Signed-off-by: Ryan Browne <[email protected]>

MadLittleMods reviewed Mar 31, 2022

View reviewed changes

src/autocomplete/EmojiProvider.tsx Show resolved Hide resolved

MadLittleMods reviewed Mar 31, 2022

View reviewed changes

turt2live reviewed Apr 4, 2022

View reviewed changes

src/autocomplete/EmojiProvider.tsx Show resolved Hide resolved

src/autocomplete/EmojiProvider.tsx Outdated Show resolved Hide resolved

src/autocomplete/EmojiProvider.tsx Outdated Show resolved Hide resolved

Ryan Browne added 6 commits April 4, 2022 01:51

Revert "Move all references to the emoji delimiter character to refer…

7cd2a97

…ence a constant." This reverts commit ac09e71. Signed-off-by: Ryan Browne <[email protected]>

Rename variable.

da10ca3

Signed-off-by: Ryan Browne <[email protected]>

Make the test file a .js file.

3f8a4fe

Signed-off-by: Ryan Browne <[email protected]>

Update quotes to match style and make a valid stubbed room.

997a5bf

Signed-off-by: Ryan Browne <[email protected]>

Fix variable name and test reporting.

6ebabf1

Signed-off-by: Ryan Browne <[email protected]>

Merge branch 'develop' into bug/element-web/issues/19302

df18446

Signed-off-by: Ryan Browne <[email protected]>

turt2live self-requested a review April 6, 2022 13:46

turt2live suggested changes Apr 9, 2022

View reviewed changes

Use str.replace with a regex.

0317419

Signed-off-by: Ryan Browne <[email protected]>

turt2live self-requested a review April 9, 2022 05:52

Ryan Browne added 3 commits April 8, 2022 22:57

Merge branch 'develop' into bug/element-web/issues/19302

10d2e3f

Use an improved regex that does not have have to iterate through the …

220cb0e

…entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <[email protected]>

turt2live approved these changes Apr 14, 2022

View reviewed changes

turt2live enabled auto-merge (squash) April 14, 2022 20:26

turt2live merged commit 08a2d81 into matrix-org:develop Apr 14, 2022

commonlawfeature deleted the bug/element-web/issues/19302 branch April 14, 2022 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve emoji autocomplete not being temporally consistent #8086

Resolve emoji autocomplete not being temporally consistent #8086

commonlawfeature commented Mar 19, 2022 •

edited by github-actions bot

Loading

MadLittleMods Mar 31, 2022 •

edited

Loading

commonlawfeature Mar 31, 2022 •

edited

Loading

MadLittleMods Mar 31, 2022

turt2live left a comment

codecov bot commented Apr 4, 2022 •

edited

Loading

commonlawfeature commented Apr 6, 2022

turt2live left a comment

commonlawfeature commented Apr 9, 2022

turt2live commented Apr 9, 2022

commonlawfeature commented Apr 9, 2022

turt2live commented Apr 9, 2022

commonlawfeature commented Apr 9, 2022

turt2live commented Apr 9, 2022

turt2live left a comment

Resolve emoji autocomplete not being temporally consistent #8086

Resolve emoji autocomplete not being temporally consistent #8086

Conversation

commonlawfeature commented Mar 19, 2022 • edited by github-actions bot Loading

🐛 Bug Fixes

MadLittleMods Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

commonlawfeature Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

MadLittleMods Mar 31, 2022

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 4, 2022 • edited Loading

Codecov Report

commonlawfeature commented Apr 6, 2022

turt2live left a comment

Choose a reason for hiding this comment

commonlawfeature commented Apr 9, 2022

turt2live commented Apr 9, 2022

commonlawfeature commented Apr 9, 2022

turt2live commented Apr 9, 2022

commonlawfeature commented Apr 9, 2022

turt2live commented Apr 9, 2022

turt2live left a comment

Choose a reason for hiding this comment

commonlawfeature commented Mar 19, 2022 •

edited by github-actions bot

Loading

MadLittleMods Mar 31, 2022 •

edited

Loading

commonlawfeature Mar 31, 2022 •

edited

Loading

codecov bot commented Apr 4, 2022 •

edited

Loading