-
-
Notifications
You must be signed in to change notification settings - Fork 829
Export Conversations #6081
Export Conversations #6081
Conversation
…existing source URLs for media
@nadonomy thanks for the review!
|
Could that be an option rather than something that will always happen? |
Yes, it could. If it is ok with the design, I'll add that option. |
I did consider this (in element-hq/element-web#19117) but it's non trivial re usability. It doesn't apply to all export methods. If we expose options contextually, we should avoid the modal resizing unexpectedly. So, we'd be looking at either some kind of multi step modal flow or a user preference. By that point, including it as a preference feels like premature optimisation and an over engineered solution. In this instance, I'd prefer to be resolute on using the light theme for now, and add options later based on learnings after shipping. |
Ok, makes sense |
@jaiwanth-v Aha! It's important the UI always gives immediate feedback where it can. Lots of these small laggy interactions add up to a whole perception of the app being slow. It's perceptible on my fast machine, I have no formal benchmark on slower machines but I'm assuming worse. We already have unique latency challenges (federation, encryption) and general performance issues so I'd prefer to not avoiding adding more debt where we can be smarter. Some ideas:
Strong preference for 1, or any other smarter ideas you might have! (cc @amshakal) |
Sure, I think 1 would be a good solution to this. |
… import jszip after export cta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recent changes look sane! Would be great if you could merge in develop once more and I can give it another round of testing whilst we wait for the ✅ from @nadonomy
d3d6214
to
d264f5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great, it works, going to land it now, will save some availability to fast follow is changes are required.
Good job @jaiwanth-v - great project!
Thanks a lot @t3chguy! |
this just closed element-hq/element-web#2630 - our 4th most upvoted issue ever. THANK YOU!!!!! |
Since this is a major feature, please include it in the changelog |
Does this feature not support export of pictures uploaded in the chat? The HTML does not contain any pictures. |
Make sure you're on an up to date version. Latest 1.11.10 |
Current Preview:
Status
(a part of gsoc'21)
Closes element-hq/element-web#2630
Signed-off-by: Jaiwanth [email protected]
Here's what your changelog entry will look like:
✨ Features