Added invite option to room's context menu

[jaiwanth-v]

Added invite option to room's context menu

Signed-off-by: Jaiwanth [email protected]

[jaiwanth-v]

[SimonBrandner]

@jaiwanth-v, could you please change the description so there isn't fixes <issue number>, so that this doesn't close the whole issue

[jaiwanth-v]

Okay

[t3chguy]

Code wise looks good other than the small nit where this.props.room && can be omitted.

Pending design review to determine if it is something we want

[niquewoodhouse]

Hi @jaiwanth-v I think this is a really good suggestion - thank you very much :) I'm one of the designers on the team, just taken a quick look and have a couple of suggested amends and a question.

Can I just confirm please if the option appears on private and public rooms? It's useful for both but I couldn't be sure from the gifs if its present for both. Thanks.

Some design proposed changes
I would like to propose some changes that might make the experience a bit easier for users:

1. Copy changes (in the context menu)

• Invite to this room Invite People (I've used a capital P just because the other things in the context menu use capital case for each word, for consistency)

2. Copy changes (in the invite dialog)

• Invite to this room Invite to room name

Reasons

1. I realise 'invite to this room' is the text used in the member list panel but its quite wordy for a small context menu which could scale to have another 4 options one day - the shorter all the text is (especially when translated), the easier it is to scan. I personally think 'invite to this room' generally is too much anyway but its really highlighted in a small context menu that's trying to be small.

2. Some people, depending on the room's sensitivity, will feel re-assured by seeing the room's name in the title of the invite dialog. There will be some users that would open, see dialog, close, re-open just to be sure it's the right room.

Thanks, let me know if you have any issues/questions/follow up for me.

[jaiwanth-v]

Hi @niquewoodhouse, yes the invite option appears both on private and public rooms. The proposed changes look good. I'll make them soon.

[t3chguy]

LGTM otherwise (again)

[t3chguy]

Thanks for your contribution!