Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

App load tweaks, i18n and localStorage #4367

Merged
merged 2 commits into from
Apr 9, 2020
Merged

App load tweaks, i18n and localStorage #4367

merged 2 commits into from
Apr 9, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 8, 2020 •
edited
Loading

  • gen-i18n missed out .ts files
  • Analytics gets loaded by the languageHandler which is used in places like rageshakesetup so is needed to be "localstorage-safe" for when it is used to show a Modernizr failure.

@t3chguy t3chguy requested a review from a team April 8, 2020 20:45
turt2live
turt2live approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/Analytics.js Show resolved Hide resolved
@t3chguy t3chguy merged commit 120e220 into develop Apr 9, 2020
@t3chguy t3chguy deleted the t3chguy/app_load2 branch April 27, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @turt2live