This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Also say "Connect ..." on remaining key backup buttons #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the remaining buttons shown when a backup exists but is not trusted so that they all now say "Connect this device to Key Backup" instead of "Use Key Backup". This is a follow up to matrix-org#2917 and was agreed with Riot iOS team element-hq/element-ios#2375 (comment). Fixes element-hq/element-web#9542
|
I think this string change is safe to land due to prior reviews of similar changes and tests are passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the remaining buttons shown when a backup exists but is not trusted
so that they all now say "Connect this device to Key Backup" instead of "Use Key
Backup".
This is a follow up to #2917 and was agreed with Riot iOS team.
Fixes element-hq/element-web#9542