-
-
Notifications
You must be signed in to change notification settings - Fork 831
Conversation
Inspired by #5453 but hopefully with the edited marker in the right place. This is a PoC: types aren't correct and the style needs pulling out to a class. Plus it would probably need more visual tests added. If this looks acceptable, I can make these changes.
I think the right hand side one was just an erroneous space character in the actual text. The one between the text and the edited marker should hopefully be simple enough to fix. |
This will cause them always be right-justified if the display name is rtl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane
As RTL user, rtl support is very useful for me. But in my opinion, this change makes the chat experience worse and not aesthetic. Excuse my poor gimp abilities, it's just to demonstrate how more aesthetic it looks having the messages on the same side with the avatars+names, even when ltr/rtl text is not adjusted correctly. |
I think there are two things to be considered separately:
Moreover, we cannot judge based on a single message look. |
Inspired by #5453 but hopefully with the edited marker in the right place.
This is now passing type checking now (albeit not hugely elegantly).
One kicker is that I've had to fix emote bodies. I've done this by wrapping them in the same way. This does mean that if you have an rtl display name, all your emotes will be right-justified, even if you're emoting in an ltr language, like so:
...this is a bit weird perhaps? But possibly the least weird of all options.
Checklist
public
/exported
symbols have accurate TSDoc documentation.