Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix inability to join a knock room via space hierarchy view #12404

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 8, 2024

@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Apr 8, 2024
@t3chguy t3chguy requested a review from a team as a code owner April 8, 2024 08:06
@t3chguy t3chguy requested review from richvdh and MidhunSureshR April 8, 2024 08:06
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests?

src/components/structures/SpaceHierarchy.tsx Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member Author

t3chguy commented Apr 8, 2024

Needs tests?

Knocking is in labs so technically it does not need tests until it leaves labs

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knocking is in labs so technically it does not need tests until it leaves labs

As discussed elsewhere, I'd really like to see some sort of test for this anyway.

Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for the test!

@t3chguy t3chguy added this pull request to the merge queue Apr 11, 2024
Merged via the queue into develop with commit 77dfc1a Apr 11, 2024
22 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/27025 branch April 11, 2024 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room knocking via spaces doesn't work
2 participants