Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept any locally known edits earlier than the last known server-side aggregated edit #986

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Jul 9, 2019

This will prevent riot showing the wrong content for an edit event if we have a later SSA edit. This does trigger element-hq/element-web#10290 when redacting the last edit but that is a lesser issue IMO, and needs fixing separately.

@bwindels bwindels requested a review from a team July 9, 2019 15:28
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunate it raises a bug, but this seems like its very much in progress anyhow

@bwindels
Copy link
Contributor Author

hmm, it's not super clear-cut which is the most important issue to solve here (where solving them both will be some work):

not seeing the correct content for an edited message when following a permalink
(under the condition that the last edit happened far enough ahead of the original event that it's not paged in when viewing the permalink)

versus

redacting the currently last edit doesn't update the content
(under the condition that there was a gappy sync when to original event was received)

Both edge cases, so fair to merge this.

@bwindels bwindels merged commit bd5380c into develop Jul 10, 2019
@t3chguy t3chguy deleted the bwindels/include-ssa-for-replace branch May 10, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants