Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic read path for relations #910

Merged
merged 2 commits into from
May 9, 2019
Merged

Add basic read path for relations #910

merged 2 commits into from
May 9, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented May 8, 2019

This adds a read path for relations (gated behind an unstable option). A few
basic client-side grouping and sorting operations are supported. Consumers are
expected to ask the EventTimelineSet for a relation container when desired.

See MSC 1849 to learn more about these events.

Part of element-hq/element-web#9485

In anticipation of relations being quite frequently used, we should intern
strings of common fields, such as `rel_type`.
@jryans jryans requested a review from a team May 8, 2019 17:04
This adds a read path for relations (gated behind an unstable option). A few
basic client-side grouping and sorting operations are supported. Consumers are
expected to ask the `EventTimelineSet` for a relation container when desired.
@jryans jryans force-pushed the jryans/aggregations branch from 22b4ec3 to 6078bbb Compare May 8, 2019 17:06
@bwindels bwindels requested review from bwindels and removed request for a team May 9, 2019 09:23
@dbkr dbkr requested review from dbkr and a team and removed request for dbkr May 9, 2019 09:26
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great so far!

src/models/relations.js Show resolved Hide resolved
src/models/room.js Show resolved Hide resolved
@jryans jryans merged commit d6abd63 into develop May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants