Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MatrixClient.initCrypto into MatrixClient.initLegacyCrypto #4567

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Rename MatrixClient.initCrypto into MatrixClient.initLegacyCrypto #4567

merged 1 commit into from
Dec 5, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Dec 3, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922
Rename MatrixClient.initCrypto into MatrixClient.initLegacyCrypto to force people to think about the deprecation.

@florianduros florianduros mentioned this pull request Dec 3, 2024
Open
@florianduros florianduros marked this pull request as ready for review December 3, 2024 09:57
@florianduros florianduros requested review from a team as code owners December 3, 2024 09:57
@florianduros florianduros changed the title Rename initCrypto into initLegacyCrypto Rename MatrixClient.initCrypto into MatrixClient.initLegacyCrypto Dec 3, 2024
@florianduros florianduros requested a review from richvdh December 3, 2024 10:03
andybalaam
andybalaam approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@andybalaam andybalaam removed the request for review from richvdh December 3, 2024 11:44
@florianduros florianduros added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@florianduros florianduros added this pull request to the merge queue Dec 5, 2024
Merged via the queue into develop with commit c54ca29 Dec 5, 2024
55 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/rename-initCrypto-initLegacyCrypto branch December 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam andybalaam approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement X-Breaking-Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @andybalaam @t3chguy