-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecate imports #4565
Merged
florianduros
merged 3 commits into
develop
from
florianduros/rip-out-legacy-crypto/deprecate-import
Nov 29, 2024
Merged
Replace deprecate imports #4565
florianduros
merged 3 commits into
develop
from
florianduros/rip-out-legacy-crypto/deprecate-import
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
T-Task
Tasks for the team like planning
T-Deprecation
A pull request that makes something deprecated
labels
Nov 28, 2024
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/deprecate-import
branch
from
November 28, 2024 15:13
dff87a1
to
df15d7f
Compare
florianduros
requested review from
andybalaam,
BillCarsonFr and
MidhunSureshR
November 28, 2024 15:20
andybalaam
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One ask, looks good.
src/common-crypto/CryptoBackend.ts
Outdated
@@ -78,6 +78,7 @@ export interface CryptoBackend extends SyncCryptoCallbacks, CryptoApi { | |||
* Get information about the encryption of an event | |||
* | |||
* @param event - event to be checked | |||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment here? What method to use instead would be helpful.
florianduros
deleted the
florianduros/rip-out-legacy-crypto/deprecate-import
branch
November 29, 2024 10:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-Deprecation
A pull request that makes something deprecated
T-Task
Tasks for the team like planning
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public
/exported
symbols have accurate TSDoc documentation.Task element-hq/element-web#26922
CryptoBackend.getEventEncryptionInfo