Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MatrixClient.getKeyBackupVersion #4505

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Deprecate MatrixClient.getKeyBackupVersion #4505

merged 1 commit into from
Nov 8, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Nov 7, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922

  • The method is using BackupManager which is from the old crypto stack.
  • The key backup methods should be exposed in the CryptoApi and not in MatrixClient

@florianduros florianduros mentioned this pull request Nov 7, 2024
Open
@florianduros florianduros added the T-Deprecation A pull request that makes something deprecated label Nov 7, 2024
@florianduros florianduros marked this pull request as ready for review November 7, 2024 16:33
@florianduros florianduros requested a review from a team as a code owner November 7, 2024 16:33
@florianduros florianduros added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit 0df8e81 Nov 8, 2024
34 of 35 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/deprecate-getKeyBackupVersion branch November 8, 2024 09:24
@florianduros florianduros mentioned this pull request Nov 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy