Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused callbacks in CryptoCallbacks #4501

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Deprecate unused callbacks in CryptoCallbacks #4501

merged 1 commit into from
Nov 6, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Nov 6, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922
Deprecate unused callbacks in CryptoCallbacks in the rust crypto stack.

@florianduros florianduros added the T-Deprecation A pull request that makes something deprecated label Nov 6, 2024
@florianduros florianduros mentioned this pull request Nov 6, 2024
Open
@florianduros florianduros marked this pull request as ready for review November 6, 2024 10:19
@florianduros florianduros requested a review from a team as a code owner November 6, 2024 10:19
@florianduros florianduros changed the title Deprecate unused callback in CryptoCallbacks Deprecate unused callbacks in CryptoCallbacks Nov 6, 2024
richvdh
richvdh approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florianduros florianduros added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@florianduros florianduros added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit 30b1894 Nov 6, 2024
42 of 43 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/deprecate-unused branch November 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh