Handle MatrixRTC encryption keys arriving out of order #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
force-pushed
the
hughns/rtc-ignore-stale-keys
branch
from
f7ec088 to
885c5a7
Compare
AndrewFerr
approved these changes
Aug 14, 2024
Comment on lines
+434
to
+436
| if (!this.encryptionKeys.has(participantId)) { | ||
| this.encryptionKeys.set(participantId, []); | ||
| } |
There was a problem hiding this comment.
There must be a tidy way to avoid all of the timestamp / keysEqual checks for when it's known from the start that there's no existing key for the participant...but since that was the case even before this PR, we can revisit this later.
Co-authored-by: Andrew Ferrazzutti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that if an older key is received after a newer one then it isn't allowed to overwrite the newer one. Resolves element-hq/element-call#2549
Checklist
public/exportedsymbols have accurate TSDoc documentation.