add resignKeyBackup, updateBackupSignature, resignKeyBackup #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods to sign the current backup again and upload it. This aims to fix the problem, that a key backup exists but no 4s, but the migration requires a resign of the backup.
github-actions
bot
added
the
Z-Community-PR
4 tasks
richvdh
reviewed
Apr 22, 2024
There was a problem hiding this comment.
See my comments on matrix-org/matrix-react-sdk#12441, but also:
resignKeyBackup feels like a very low-level, and dangerous primitive to expose. I really don't want applications to have to decide to arbitrarily re-sign existing key backups.
If this is a thing that we need to support, maybe we can make it part of bootstrapCrossSigning ?
|
|
||
| await signObject(authData); | ||
|
|
||
| // An alternative implementation could be using src\crypto\EncryptionSetup.ts and EncryptionSetupOperation, similar to: |
There was a problem hiding this comment.
that stuff is deprecated; let's not use it.
|
As with matrix-org/matrix-react-sdk#12441: I don't really think this is the right thing to be doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using key backups without 4s (secure secret storage and sharing) and signing in with the web-client then no migration is performed and the session cannot backup keys without any further user interaction (resetting cross signing (and key backup)).
This seems to be related to: element-hq/element-web#27100
ToDo: If the above is correct then a note for the Changelog will be added.
The changes here depend on the changes in matrix-react-sdk PR 12441 .
Checklist
public/exportedsymbols have accurate TSDoc documentation.Signed-off-by: Michael Schrader [email protected]