Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element R: Add test that requests are encoded properly #4033

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Element R: Add test that requests are encoded properly #4033

merged 2 commits into from
Jan 26, 2024

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jan 25, 2024 •
edited by github-actions bot
Loading

Tests that matrix-org/matrix-rust-sdk-crypto-wasm#72 fixes element-hq/element-web#26566

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@uhoreg uhoreg changed the title dd test that requests are encoded properly Element R: Add test that requests are encoded properly Jan 25, 2024
@uhoreg uhoreg added the T-Task Tasks for the team like planning label Jan 25, 2024
@uhoreg
Copy link
Member Author

uhoreg commented Jan 25, 2024

Only tests that matrix-org/matrix-rust-sdk-crypto-wasm#57 is fixed. I think that for matrix-org/matrix-rust-sdk-crypto-wasm#56, I think it needs a lot more setup to get the OlmMachine to emit the right requests. So if this is enough to show that matrix-org/matrix-rust-sdk-crypto-wasm#72 is working, then I'll keep it as-is.

@uhoreg uhoreg marked this pull request as ready for review January 25, 2024 03:16
@uhoreg uhoreg requested a review from a team as a code owner January 25, 2024 03:16
@uhoreg uhoreg requested review from andybalaam and richvdh January 25, 2024 03:16
andybalaam
andybalaam approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, and it looks good although my understanding of this algorithm is minimal.

spec/unit/rust-crypto/rust-crypto.spec.ts Outdated Show resolved Hide resolved
@uhoreg uhoreg added this pull request to the merge queue Jan 26, 2024
Merged via the queue into matrix-org:develop with commit 5967c67 Jan 26, 2024
20 checks passed
@uhoreg uhoreg deleted the request_transform_test branch January 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element Web R can't send encrypted messages on dendrite/conduit
2 participants
@uhoreg @andybalaam