-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a mechanism for using the rust-crypto-sdk #2969
Changes from 3 commits
60f642f
c0adbf3
dbb07f6
c33afe2
2893717
d4a54b2
df8d44b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
/* | ||
Copyright 2022 The Matrix.org Foundation C.I.C. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
import "fake-indexeddb/auto"; | ||
import { IDBFactory } from "fake-indexeddb"; | ||
|
||
import { createClient } from "../../src"; | ||
|
||
afterEach(() => { | ||
// reset fake-indexeddb after each test, to make sure we don't leak connections | ||
// cf https://github.com/dumbmatter/fakeIndexedDB#wipingresetting-the-indexeddb-for-a-fresh-state | ||
// eslint-disable-next-line no-global-assign | ||
indexedDB = new IDBFactory(); | ||
}); | ||
|
||
describe("MatrixClient.initRustCrypto", () => { | ||
it("should raise if userId or deviceId is unknown", async () => { | ||
const unknownUserClient = createClient({ | ||
baseUrl: "http://test.server", | ||
deviceId: "aliceDevice", | ||
}); | ||
await expect(() => unknownUserClient.initRustCrypto()).rejects.toThrow("unknown userId"); | ||
|
||
const unknownDeviceClient = createClient({ | ||
baseUrl: "http://test.server", | ||
userId: "@alice:test", | ||
}); | ||
await expect(() => unknownDeviceClient.initRustCrypto()).rejects.toThrow("unknown deviceId"); | ||
}); | ||
|
||
it("should create the indexed dbs", async () => { | ||
const matrixClient = createClient({ | ||
baseUrl: "http://test.server", | ||
userId: "@alice:localhost", | ||
deviceId: "aliceDevice", | ||
}); | ||
|
||
// No databases. | ||
expect(await indexedDB.databases()).toHaveLength(0); | ||
|
||
await matrixClient.initRustCrypto(); | ||
|
||
// should have two dbs now | ||
const databaseNames = (await indexedDB.databases()).map((db) => db.name); | ||
expect(databaseNames).toEqual( | ||
expect.arrayContaining(["matrix-js-sdk::matrix-sdk-crypto", "matrix-js-sdk::matrix-sdk-crypto-meta"]), | ||
); | ||
}); | ||
|
||
it("should ignore a second call", async () => { | ||
const matrixClient = createClient({ | ||
baseUrl: "http://test.server", | ||
userId: "@alice:localhost", | ||
deviceId: "aliceDevice", | ||
}); | ||
|
||
await matrixClient.initRustCrypto(); | ||
await matrixClient.initRustCrypto(); | ||
}); | ||
}); | ||
|
||
describe("MatrixClient.clearStores", () => { | ||
it("should clear the indexeddbs", async () => { | ||
const matrixClient = createClient({ | ||
baseUrl: "http://test.server", | ||
userId: "@alice:localhost", | ||
deviceId: "aliceDevice", | ||
}); | ||
|
||
await matrixClient.initRustCrypto(); | ||
expect(await indexedDB.databases()).toHaveLength(2); | ||
await matrixClient.stopClient(); | ||
|
||
await matrixClient.clearStores(); | ||
expect(await indexedDB.databases()).toHaveLength(0); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
Copyright 2022 The Matrix.org Foundation C.I.C. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
import * as RustSdkCryptoJs from "@matrix-org/matrix-sdk-crypto-js"; | ||
|
||
import { RustCrypto } from "./rust-crypto"; | ||
import { logger } from "../logger"; | ||
import { CryptoBackend } from "../common-crypto/CryptoBackend"; | ||
|
||
export async function initRustCrypto(userId: string, deviceId: string): Promise<CryptoBackend> { | ||
// initialise the rust matrix-sdk-crypto-js, if it hasn't already been done | ||
await RustSdkCryptoJs.initAsync(); | ||
|
||
// enable tracing in the rust-sdk | ||
new RustSdkCryptoJs.Tracing(RustSdkCryptoJs.LoggerLevel.Debug).turnOn(); | ||
|
||
const u = new RustSdkCryptoJs.UserId(userId); | ||
const d = new RustSdkCryptoJs.DeviceId(deviceId); | ||
logger.info("Init OlmMachine"); | ||
|
||
// TODO: use the pickle key for the passphrase | ||
const olmMachine = await RustSdkCryptoJs.OlmMachine.initialize(u, d, "matrix-js-sdk", "test pass"); | ||
const rustCrypto = new RustCrypto(olmMachine, userId, deviceId); | ||
|
||
logger.info("Completed rust crypto-sdk setup"); | ||
return rustCrypto; | ||
} |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,60 @@ | ||||||||
/* | ||||||||
Copyright 2022 The Matrix.org Foundation C.I.C. | ||||||||
|
||||||||
Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||
you may not use this file except in compliance with the License. | ||||||||
You may obtain a copy of the License at | ||||||||
|
||||||||
http://www.apache.org/licenses/LICENSE-2.0 | ||||||||
|
||||||||
Unless required by applicable law or agreed to in writing, software | ||||||||
distributed under the License is distributed on an "AS IS" BASIS, | ||||||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||
See the License for the specific language governing permissions and | ||||||||
limitations under the License. | ||||||||
*/ | ||||||||
|
||||||||
import * as RustSdkCryptoJs from "@matrix-org/matrix-sdk-crypto-js"; | ||||||||
|
||||||||
import { IEventDecryptionResult } from "../@types/crypto"; | ||||||||
import { MatrixEvent } from "../models/event"; | ||||||||
import { CryptoBackend } from "../common-crypto/CryptoBackend"; | ||||||||
|
||||||||
// import { logger } from "../logger"; | ||||||||
|
||||||||
/** | ||||||||
* An implementation of {@link CryptoBackend} using the Rust matrix-sdk-crypto. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
or whatever jsdoc wants to say this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. alternatively, apparently There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, it's not exported explicitly, and it's only dynamically referenced, so it doesn't actually appear in the generated documentation. |
||||||||
*/ | ||||||||
export class RustCrypto implements CryptoBackend { | ||||||||
public globalBlacklistUnverifiedDevices = false; | ||||||||
public globalErrorOnUnknownDevices = false; | ||||||||
|
||||||||
/** whether stop() has been called */ | ||||||||
private stopped = false; | ||||||||
|
||||||||
public constructor(private readonly olmMachine: RustSdkCryptoJs.OlmMachine, _userId: string, _deviceId: string) {} | ||||||||
|
||||||||
public stop(): void { | ||||||||
// stop() may be called multiple times, but attempting to close() the OlmMachine twice | ||||||||
// will cause an error. | ||||||||
if (this.stopped) { | ||||||||
return; | ||||||||
} | ||||||||
this.stopped = true; | ||||||||
|
||||||||
// make sure we close() the OlmMachine; doing so means that all the Rust objects will be | ||||||||
// cleaned up; in particular, the indexeddb connections will be closed, which means they | ||||||||
// can then be deleted. | ||||||||
this.olmMachine.close(); | ||||||||
} | ||||||||
|
||||||||
public async decryptEvent(event: MatrixEvent): Promise<IEventDecryptionResult> { | ||||||||
await this.olmMachine.decryptRoomEvent("event", new RustSdkCryptoJs.RoomId("room")); | ||||||||
throw new Error("not implemented"); | ||||||||
} | ||||||||
|
||||||||
public async userHasCrossSigningKeys(): Promise<boolean> { | ||||||||
// TODO | ||||||||
return false; | ||||||||
} | ||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to recall that these database names are in a constant somewhere? If so, we should use them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, we should consider making them constants for reasons of reliability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, tbh: they are defined in the rust-sdk here and here.
Given they are only used once, I'm unconvinced that a constant will help reliability.
The prefix does come from the js-sdk so I can factor that out to a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in df8d44b.