Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instanceof Array with Array.isArray #2812

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Replace instanceof Array with Array.isArray #2812

merged 1 commit into from
Oct 26, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 26, 2022 •
edited by github-actions bot
Loading

Fixes #2811

Here's what your changelog entry will look like:

🐛 Bug Fixes

@t3chguy t3chguy requested a review from a team as a code owner October 26, 2022 15:51
@t3chguy t3chguy mentioned this pull request Oct 26, 2022
Closed
3 tasks
turt2live
turt2live approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably lint for this, but happy for that to be a different/future PR.

@t3chguy t3chguy merged commit b447871 into develop Oct 26, 2022
@t3chguy t3chguy deleted the t3chguy/instanceof branch October 26, 2022 16:59
@freaktechnik
Copy link
Contributor

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-instanceof-array.md is an eslint rule for this I'm aware of.

@t3chguy
Copy link
Member Author

t3chguy commented Oct 31, 2022

@freaktechnik thanks, will inherit

su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Nov 12, 2022
@su-ex
Merge tag 'v21.1.0' into sc
1474204 
* Loading threads with server-side assistance ([\matrix-org#2735](matrix-org#2735)). Contributed by @justjanne.
* Support sign in + E2EE set up using QR code implementing MSC3886, MSC3903 and MSC3906 ([\matrix-org#2747](matrix-org#2747)). Contributed by @hughns.
* Replace `instanceof Array` with `Array.isArray` ([\matrix-org#2812](matrix-org#2812)). Fixes matrix-org#2811.
* Emit UnreadNotification event on notifications reset ([\matrix-org#2804](matrix-org#2804)). Fixes element-hq/element-web#23590.
* Fix incorrect prevEv being sent in ClientEvent.AccountData events ([\matrix-org#2794](matrix-org#2794)).
* Fix build error caused by wrong ts-strict improvements ([\matrix-org#2783](matrix-org#2783)). Contributed by @justjanne.
* Encryption should not hinder verification ([\matrix-org#2734](matrix-org#2734)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAS.ts assumes arrays are from the same JS realm
3 participants
@t3chguy @freaktechnik @turt2live