Apply more strict typescript around the codebase #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chguy/tsc-strict2 � Conflicts: � src/sync.ts
|
Increases overall coverage from 67.6% to 68% - infeasible to hit 80% mark with this typing fix. |
kerryarchibald
approved these changes
Oct 20, 2022
| @@ -109,10 +109,10 @@ export class UnstableValue<S extends string, U extends string> extends Namespace | |||
| } | |||
|
|
|||
| public get name(): U { | |||
| return this.unstable; | |||
| return this.unstable!; | |||
There was a problem hiding this comment.
Should be U | undefined return type rather than non-null assertion
There was a problem hiding this comment.
The constructor says
// Stable is optional, but one of the two parameters is required, hence the weird-looking types.
// Goal is to to have developers explicitly say there is no stable value (if applicable).
So we can assert it will be defined given the stable wasn't. Will try express it with an overload
| @@ -685,14 +686,6 @@ export class MatrixEvent extends TypedEventEmitter<MatrixEventEmittedEvents, Mat | |||
| * attempt is completed. | |||
| */ | |||
| public async attemptDecryption(crypto: Crypto, options: IDecryptOptions = {}): Promise<void> { | |||
| // For backwards compatibility purposes | |||
There was a problem hiding this comment.
Should this qualify as a breaking change even though the signature is unchanged?
There was a problem hiding this comment.
The type didn't allow for the backwards compatibility so it got partially removed at some point in the past
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#9474
This change is marked as an internal change (Task), so will not be included in the changelog.