Prevent double mute status changed events #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio & video mute status were set in separate calls but share a mute status changed event, so you'd always get two mute status changed events emitted. We could suppress events where the mute status didn't change, but this would still get two events saying the same thing when they both changed. Instead, merge setAudioMuted & setVideoMuted into a single call that sets either or both. Port of #2502 from group call branch
dbkr
changed the title
t3chguy
approved these changes
Jul 13, 2022
| * @param muted is the feed's video muted? | ||
| */ | ||
| public setVideoMuted(muted: boolean): void { | ||
| this.videoMuted = muted; | ||
| public setAudioVideoMuted(audioMuted: boolean, videoMuted: boolean): void { |
There was a problem hiding this comment.
Marked this as a breaking change, any chance you fancy keeping the old ones around for compatibility but just calling the new one under the hood?
There was a problem hiding this comment.
This is just internal js-sdk API, so shouldn't need to be a breaking change (although of course it's a public method on an object that the API consumer gets given, so they could call it, but it wouldn't really do anything useful).
There was a problem hiding this comment.
I would argue that there could be a client that is actually using this - we have placeCallWithCallFeeds() so a client could construct its own CallFeeds and manipulate them
weeman1337
approved these changes
Jul 19, 2022
|
@dbkr, I think this can be merged now? |
|
so it can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio & video mute status were set in separate calls but share a
mute status changed event, so you'd always get two mute status
changed events emitted. We could suppress events where the mute
status didn't change, but this would still get two events saying
the same thing when they both changed. Instead, merge setAudioMuted
& setVideoMuted into a single call that sets either or both.
Port of #2502 from
group call branch
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.