Skip to content

Commit

Permalink
Add throwOnFail to groupCall.setScreensharingEnabled (#2787)
Browse files Browse the repository at this point in the history
* Add throwOnFail to groupCall.setScreensharingEnabled

For element-hq/element-call#652

* Update mediaHandler.ts
  • Loading branch information
dbkr authored Oct 24, 2022
1 parent 5a07873 commit eddd0ca
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/webrtc/groupCall.ts
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,7 @@ export class GroupCall extends TypedEventEmitter<

return true;
} catch (error) {
if (opts.throwOnFail) throw error;
logger.error("Enabling screensharing error", error);
this.emit(GroupCallEvent.Error,
new GroupCallError(GroupCallErrorCode.NoUserMedia, "Failed to get screen-sharing stream: ", error),
Expand Down
5 changes: 5 additions & 0 deletions src/webrtc/mediaHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export type MediaHandlerEventHandlerMap = {
export interface IScreensharingOpts {
desktopCapturerSourceId?: string;
audio?: boolean;
// For electron screen capture, there are very few options for detecting electron
// apart from inspecting the user agent or just trying getDisplayMedia() and
// catching the failure, so we do the latter - this flag tells the function to just
// throw an error so we can catch it in this case, rather than logging and emitting.
throwOnFail?: boolean;
}

export class MediaHandler extends TypedEventEmitter<
Expand Down

0 comments on commit eddd0ca

Please sign in to comment.