Restore createKeyWithKeyId
#1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
commented
Oct 23, 2024
| } | ||
| else | ||
| { | ||
| OLMPkDecryption *decryption = [OLMPkDecryption new]; |
There was a problem hiding this comment.
This uses OLMKit
I think it's just generating 32 random bytes, you can replace with SecRandomCopyBytes
There was a problem hiding this comment.
@BillCarsonFr okay I think I have replaced it correctly, let me know if this is fine and we can merge it
…auroromito/restore_create_key_with_id
BillCarsonFr
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.