Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CallKit maximumCallGroups configurable #1738

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

manuroe
Copy link
Contributor

@manuroe manuroe commented Mar 13, 2023

This PR supersedes #1581 to cover call transfer about other use cases too.

@manuroe manuroe force-pushed the manu/callkit_maximumCallGroups branch from b072206 to b63e064 Compare March 13, 2023 17:46
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -19.84 ⚠️

Comparison is base (5388409) 37.51% compared to head (b63e064) 17.67%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1738       +/-   ##
============================================
- Coverage    37.51%   17.67%   -19.84%     
============================================
  Files          612      612               
  Lines        96549    96547        -2     
  Branches     41733    40518     -1215     
============================================
- Hits         36219    17066    -19153     
- Misses       59282    78968    +19686     
+ Partials      1048      513      -535     
Impacted Files Coverage Δ
MatrixSDK/VoIP/CallKit/MXCallKitConfiguration.m 0.00% <0.00%> (ø)

... and 197 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manuroe manuroe requested review from a team and pixlwave and removed request for a team March 14, 2023 08:36
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manuroe manuroe merged commit 3253769 into develop Mar 14, 2023
@manuroe manuroe deleted the manu/callkit_maximumCallGroups branch March 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants