Fully deprecate MXCryptoStore #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/legacy_store
branch
3 times, most recently
from
2e6bdc3 to
3b615b7
Compare
Anderas
requested review from
a team,
flescio and
BillCarsonFr
and removed request for
a team
|
Note that the PR will not build as i've not yet published new rust crypto framework (waiting to merge the associated PR) |
Anderas
force-pushed
the
andy/legacy_store
branch
from
3b615b7 to
65f1881
Compare
Anderas
force-pushed
the
andy/legacy_store
branch
2 times, most recently
from
a56ec0e to
79158f7
Compare
Anderas
force-pushed
the
andy/legacy_store
branch
from
79158f7 to
6ed38f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves element-hq/element-ios#7419
Related rust-sdk change: matrix-org/matrix-rust-sdk#1460
Until now the rust-based Crypto V2 still required access to the legacy Realm crypto database to store the following data:
The rust-sdk can now store this data as well (after the above PR is merged) so we can fully deprecate the
MXCryptoStorein the ios sdk.Because there are already clients in production that have migrated from legacy to rust crypto we need to consider several use cases for migration of settings:
This is achieved by adding another
MXCryptoVersioncase and migrating in steps depending on the current version.