This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Fix dialogs being blurry and not scrollable #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
bd2a555
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://39056b34.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-fix-modal.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/frontend/fix-modal-scroll
branch
from
a1fd81c to
0d84fe5
Compare
This positions dialogs with a flexbox layout, which avoids the weird bluriness due to `transform: translate` and allows the dialog to be scrollable. It also adds a story which has a long content to test the scrollability.
sandhose
force-pushed
the
quenting/frontend/fix-modal-scroll
branch
from
0d84fe5 to
bd2a555
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This positions dialogs with a flexbox layout, which avoids the weird bluriness due to
transform: translateand allows the dialog to be scrollable.Story to try out: https://quenting-frontend-fix-modal.matrix-authentication-service-docs.pages.dev/storybook/?path=/story/ui-dialog--long-text