This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Make the end session button more flexible #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1af80c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9a6ebfbf.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-end-sessio.matrix-authentication-service-docs.pages.dev |
t3chguy
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unnecessarily generic
<ConfirmationModal />and uses theDialogcomponents directly in theEndSessionButton.It makes the button closer to the design
It also makes the loading indicator within the modal instead of the trigger
It makes it possible to have children in the
EndSessionButtonwhich will appear in the modal description. This will make it possible later to say which session is being ended.There is a story to see the button in action: https://quenting-frontend-end-sessio.matrix-authentication-service-docs.pages.dev/storybook/?path=/story/ui-session-end-session-button--with-children