Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Remove the unique constraint on device IDs on compatibility sessions #2378

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

sandhose
Copy link
Member

In OAuth 2.0 sessions, we can have multiple sessions for the same device
anyway, so this constraint doesn't exactly make sense.

Fixes #2033
Fixes #2312

@sandhose sandhose added A-Migration Related to the migration tooling A-Compatibility-Layer Related to the legacy Matrix authentication compatibility layer labels Feb 20, 2024
Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba6178f
Status: ✅  Deploy successful!
Preview URL: https://08800408.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-compat-sessions-uni.matrix-authentication-service-docs.pages.dev

View logs

In OAuth 2.0 sessions, we can have multiple sessions for the same device
anyway, so this constraint doesn't exactly make sense.

Fixes #2033
Fixes #2312
@sandhose sandhose force-pushed the quenting/compat-sessions-unique branch from 7283f27 to ba6178f Compare February 20, 2024 14:34
@sandhose sandhose merged commit 03b6ad7 into main Feb 20, 2024
18 checks passed
@sandhose sandhose deleted the quenting/compat-sessions-unique branch February 28, 2024 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Compatibility-Layer Related to the legacy Matrix authentication compatibility layer A-Migration Related to the migration tooling
Projects
None yet
1 participant