This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Use query parameters for sessions pagination #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reverses the order of the sessions to show the most recent ones first. Fixes #1497
sandhose
added
A-Frontend
Deploying with
|
| Latest commit: |
3394e0d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7793fd75.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-better-ses.matrix-authentication-service-docs.pages.dev |
This means we should almost never see a loading spinner when navigating
sandhose
changed the title
t3chguy
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that next/previous buttons are actually links, and that browser history works as expected.
It also means we can load everything in route loaders, which means we can preload next pages and almost never show a loading spinner
Also reverses the order of the sessions to show the most recent ones first.
Fixes #1497