This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Replace Jotai with @tanstack/router #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes sure everything is properly loaded in the route loader, and we use fragment where it makes sense
Deploying with
|
| Latest commit: |
7d62593
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa7a253b.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-remove-jotai.matrix-authentication-service-docs.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces Jotai completely with @tanstack/router.
Fixes #1713
This makes the routing much simpler to understand, as it uses a file-based structure to define routes.
It makes defining error boundaries and not found boundaries way easier.
It makes it way easier to pre-load data before changing pages
The nested routing should help making the individual session view a modal on top of the list.
The main thing that changes are the URLs.
/sessions-overview->/sessions/browser-sessions->/sessions/browsers/session/:deviceId->/sessions/:id(note that we now use the session ID here, not the device ID)/devices/:deviceIdnow redirects to the corresponding/sessions/:idpageA few points of interest when looking at the code:
src/routes/__root.tsxhas the MSC2965 ?action parameter handlingsrc/routes/_account.tsx: for pages which uses the user greeting + tabs, this "ghost" page is used to define this common layout, but without applying it to all pages.test-utils/router.tsxhas a test helper to create a dummy router with just an index route, which renders whatever children you give it