Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

syn2mas: Skip access tokens that don't have a device ID #2317

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jaywink
Copy link
Member

@jaywink jaywink commented Feb 6, 2024

These can't be migrated. They are likely enirely valid tokens created by puppeting a user via the Synapse admin api. Treating them as fatal errors will make it impossible to migrate any host that has ever used this admin API feature.

These can't be migrated. They are likely enirely valid tokens created by puppeting a user via the Synapse admin api. Treating them as fatal errors will make it impossible to migrate any host that has ever used this admin API feature.
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me, although I wonder if we should mention that in the migration docs? At least it warns about it in the advisor, so it's probably fine for now 👍

@jaywink
Copy link
Member Author

jaywink commented Feb 8, 2024

This change makes sense to me, although I wonder if we should mention that in the migration docs? At least it warns about it in the advisor, so it's probably fine for now 👍

Have tried to clarify in the docs 👍

@sandhose sandhose merged commit ea223a2 into matrix-org:main Feb 8, 2024
17 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants