Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid Discord tokens gracefully #746

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented Nov 11, 2021

732be16 ensures we don't crash on startup, and thus not crashloop if the token has been regenerated or configured incorrectly.

09a3631 proposes a way to notify a bridge admin (optional, configurable) about the startup problems.

Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial thoughts

src/discordas.ts Outdated Show resolved Hide resolved
src/discordas.ts Outdated Show resolved Hide resolved
src/discordas.ts Outdated Show resolved Hide resolved
src/discordas.ts Outdated Show resolved Hide resolved
@tadzik tadzik requested a review from Half-Shot November 12, 2021 15:15
src/discordas.ts Outdated Show resolved Hide resolved
src/discordas.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tested, this looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants