Adjust preview channel condition #22202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We've changed the approach from
-preview
to-pYYYYmmddHHiiss
so this is just adjusting the script to be aware of that and not treat tags with the-p...
suffix as stable releases.Additionally this fixes the build server check as
$F
wasn't defined at that point so the file never existed and the check always succeeded.Adds a new check for preview version to
core/Version.php
from where we can use it in other parts of Matomo as well as in the build script to determine if a version is a preview version without duplicating the same logic in a convoluted way in a bash script.Review