Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust preview channel condition #22202

Merged
merged 5 commits into from
May 9, 2024

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented May 9, 2024

Description:

We've changed the approach from -preview to -pYYYYmmddHHiiss so this is just adjusting the script to be aware of that and not treat tags with the -p... suffix as stable releases.

Additionally this fixes the build server check as $F wasn't defined at that point so the file never existed and the check always succeeded.

Adds a new check for preview version to core/Version.php from where we can use it in other parts of Matomo as well as in the build script to determine if a version is a preview version without duplicating the same logic in a convoluted way in a bash script.

Review

The check only outputs an error message that the version already exists but doesn't prevent the build from continuing.
The release downloader will skip release archives for versions it already downloaded before.
@michalkleiner michalkleiner requested a review from caddoo May 9, 2024 03:17
@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Better processes Indicates an issue is about improving how we work. labels May 9, 2024
@michalkleiner michalkleiner added this to the 5.1.0 milestone May 9, 2024
@michalkleiner michalkleiner force-pushed the DEV-18041-adjust-preview-channel-condition branch from 04b9e44 to a60aa6a Compare May 9, 2024 05:01
@michalkleiner michalkleiner merged commit a0f7182 into 5.x-dev May 9, 2024
20 of 25 checks passed
@michalkleiner michalkleiner deleted the DEV-18041-adjust-preview-channel-condition branch May 9, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Better processes Indicates an issue is about improving how we work. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants