fixes #61

mathiask88 · Nov 22, 2020 · 486b268 · 486b268
1 parent 171748a
commit 486b268
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/doc/client.md b/doc/client.md
@@ -540,11 +540,13 @@ Returns an `object` (see [example](#example-blockinfo) above) on success or `fal
 
 ----------
 
-#### <a name="full-upload"></a>S7Client.FullUpload(blockType, blockNum[, callback])
+#### <a name="full-upload"></a>S7Client.FullUpload(blockType, blockNum, size[, callback])
 Uploads a block from AG. The whole block (including header and footer) is copied into the user buffer.
 
  - `blockType` Type of block (see table [above](#table-blocktype))
  - `blockNum` Number of block
+ - `size` Buffer size (if smaller than the data
+uploaded, only `size` bytes are copied and `errCliPartialDataRead` is returned)
  - The optional `callback` parameter will be executed after completion
 
 If `callback` is **not** set the function is **blocking** and returns a `Buffer` object on success or `false` on error.<br />

diff --git a/src/node_snap7_client.cpp b/src/node_snap7_client.cpp
@@ -1764,8 +1764,8 @@ NAN_METHOD(S7Client::FullUpload) {
     return Nan::ThrowTypeError("Wrong arguments");
   }
 
-  char *bufferData = new char[Nan::To<int32_t>(info[2]).FromJust()];
   int size = Nan::To<int32_t>(info[2]).FromJust();
+  char *bufferData = new char[size];
   if (!info[3]->IsFunction()) {
     int returnValue = s7client->snap7Client->FullUpload(
 		Nan::To<int32_t>(info[0]).FromJust(), Nan::To<int32_t>(info[1]).FromJust(), bufferData, &size);