Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revamp deploySc #1371

Merged
merged 36 commits into from
Dec 10, 2024
Merged

revamp deploySc #1371

merged 36 commits into from
Dec 10, 2024

Conversation

pivilartisant
Copy link
Contributor

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.

  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label

  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?

  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@pivilartisant pivilartisant force-pushed the revamp-deploy-sc branch 2 times, most recently from edd9863 to 722e432 Compare December 3, 2024 20:48
@pivilartisant pivilartisant changed the title revamp deploy api endpoint revamp deploySc Dec 3, 2024
thomas-senechal
thomas-senechal reviewed Dec 5, 2024
View reviewed changes
api/test/robot_tests/variables.resource Outdated Show resolved Hide resolved
api/test/robot_tests/keywords.resource Outdated Show resolved Hide resolved
int/api/cmd/sc/deployer.wasm Outdated Show resolved Hide resolved
pivilartisant
pivilartisant commented Dec 5, 2024
View reviewed changes
int/api/cmd/deploySC.go Outdated Show resolved Hide resolved
peterjah
peterjah reviewed Dec 5, 2024
View reviewed changes
int/api/cmd/deploySC.go Outdated Show resolved Hide resolved
peterjah
peterjah reviewed Dec 5, 2024
View reviewed changes
pkg/onchain/sc.go Outdated Show resolved Hide resolved
@thomas-senechal thomas-senechal merged commit 83b2778 into main Dec 10, 2024
15 checks passed
@thomas-senechal thomas-senechal deleted the revamp-deploy-sc branch December 10, 2024 08:40
@pivilartisant pivilartisant linked an issue Dec 12, 2024 that may be closed by this pull request
Refactor MassaStation API to enable deploy SC massalabs/DeWeb#174
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

@thomas-senechal thomas-senechal thomas-senechal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor MassaStation API to enable deploy SC
3 participants
@pivilartisant @peterjah @thomas-senechal