Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete Fn in Cache pkg #1365

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Add Delete Fn in Cache pkg #1365

merged 5 commits into from
Aug 14, 2024

Conversation

pivilartisant
Copy link
Contributor

@pivilartisant pivilartisant commented Aug 8, 2024

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/cache/cache.go Outdated Show resolved Hide resolved
pivilartisant and others added 3 commits August 9, 2024 11:12
Co-authored-by: Nathan Seva <[email protected]>
Co-authored-by: Nathan Seva <[email protected]>
@pivilartisant pivilartisant requested a review from Thykof August 9, 2024 11:57
pkg/cache/cache.go Outdated Show resolved Hide resolved
Co-authored-by: Thomas Sénéchal <[email protected]>
@thomas-senechal thomas-senechal merged commit 9abe688 into main Aug 14, 2024
15 checks passed
@thomas-senechal thomas-senechal deleted the add-delete-cache branch August 14, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that website are remove from cache after deleting them on chain
3 participants