Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: refactor handling of version #1359

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented May 14, 2024

QA

here https://github.com/massalabs/station/releases see the draft release v0.6.5, downlaod the installer and try to install, have a look at the version in the UI

  • win11
  • mac arm
  • mac amd
  • ubuntu

@Thykof Thykof linked an issue May 14, 2024 that may be closed by this pull request
@Thykof Thykof force-pushed the 1289-simplify-version-variable-ci branch from b47a751 to 008921b Compare May 14, 2024 17:29
@Thykof Thykof requested a review from thomas-senechal May 14, 2024 18:20
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we need to test every installers to make sure they are all working fine, and we also need to find a way to test if the updates are still working

@Thykof
Copy link
Contributor Author

Thykof commented May 15, 2024

Looks good to me, but we need to test every installers to make sure they are all working fine, and we also need to find a way to test if the updates are still working

Yes to QA we need all OS.

For the update, do you mean the red dot pin in the icon tray?

@thomas-senechal
Copy link
Member

For the update, do you mean the red dot pin in the icon tray?

Yes
I'm worried that the version comparison might broke

@Thykof
Copy link
Contributor Author

Thykof commented May 16, 2024

For the update, do you mean the red dot pin in the icon tray?

Yes I'm worried that the version comparison might broke

I tried and it will work. Moreover the version check works well whatever you put v0.0.0 or 0.0.0

@Thykof Thykof merged commit 38919f7 into main May 17, 2024
25 checks passed
@Thykof Thykof deleted the 1289-simplify-version-variable-ci branch May 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the version variable in the build CI workflow
2 participants