Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dashboard plugin update #1351

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Enable dashboard plugin update #1351

merged 12 commits into from
Apr 24, 2024

Conversation

pivilartisant
Copy link
Contributor

@pivilartisant pivilartisant commented Apr 22, 2024

Changes:

Plugin Wallet is now a component hosted in station repo (not ui-kit)
Update Plugin logic is contained in a custom hook and called in two places: dashboard and plugin store

These changes enables the user to directly update MW plugin in the dashboard ui without having to navigate to the plugin store

@pivilartisant pivilartisant linked an issue Apr 22, 2024 that may be closed by this pull request
@pivilartisant pivilartisant force-pushed the enable-plugin-dashboard-update branch from a6d91ba to 06db72a Compare April 22, 2024 15:53
@pivilartisant pivilartisant requested a review from Thykof April 22, 2024 15:57
@pivilartisant pivilartisant requested a review from Thykof April 23, 2024 08:12
@pivilartisant pivilartisant linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.87%. Comparing base (10c1fe2) to head (0506895).
Report is 4 commits behind head on main.

❗ Current head 0506895 differs from pull request most recent head 07f871e. Consider uploading reports for the commit 07f871e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
- Coverage   22.09%   15.87%   -6.23%     
==========================================
  Files          29       24       -5     
  Lines        1715     1531     -184     
==========================================
- Hits          379      243     -136     
+ Misses       1326     1279      -47     
+ Partials       10        9       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof dismissed their stale review April 24, 2024 12:16

my comment is resolved

@Thykof Thykof force-pushed the enable-plugin-dashboard-update branch from d4124c2 to f324722 Compare April 24, 2024 12:41
@Thykof Thykof merged commit ba149a9 into main Apr 24, 2024
15 checks passed
@Thykof Thykof deleted the enable-plugin-dashboard-update branch April 24, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users can update mw plugin directly in the dashboard Improve picto in module page
2 participants